Skip to content

chore: replace snapshottest with syrupy and support py3.12 #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

chore: replace snapshottest with syrupy and support py3.12 #1118

merged 2 commits into from
Aug 27, 2025

Conversation

GG-HH
Copy link
Collaborator

@GG-HH GG-HH commented Aug 7, 2025 •
edited
Loading

Context

An attempt to fix #832 and bring python3.12 support.

What has been done

  1. Replace snapshottest with syrupy
  2. Add py3.12 in the test matrix

Validation

Run tests with a python3.12 environment
Ensure there is nowhere where I should update to python3.12 that was forgotten

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@codecov Codecov
Copy link

codecov bot commented Aug 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (bad74e6) to head (13cf4bf).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         144      144           
  Lines        6162     6162           
=======================================
  Hits         5669     5669           
  Misses        493      493
Flag Coverage Δ
unittests 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GG-HH GG-HH self-assigned this Aug 7, 2025
@GG-HH GG-HH mentioned this pull request Aug 7, 2025
Closed
agateau-gg
agateau-gg reviewed Aug 19, 2025
View reviewed changes
@GG-HH GG-HH marked this pull request as ready for review August 25, 2025 13:09
@GG-HH GG-HH requested a review from a team as a code owner August 25, 2025 13:09
@sevbch sevbch requested a review from agateau-gg August 26, 2025 16:02
agateau-gg
agateau-gg approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@agateau-gg agateau-gg force-pushed the gg-hh/832/replace_snapshottest branch from 9d2d829 to 13cf4bf Compare August 27, 2025 07:35
@agateau-gg agateau-gg enabled auto-merge August 27, 2025 07:36
@agateau-gg agateau-gg merged commit ef7aa67 into main Aug 27, 2025
31 checks passed
@agateau-gg agateau-gg deleted the gg-hh/832/replace_snapshottest branch August 27, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agateau-gg agateau-gg agateau-gg approved these changes

Assignees

@GG-HH GG-HH

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GGShield test suite fails with Python 3.12
2 participants
@GG-HH @agateau-gg